Fix test failure when building OTP in a path with special characters #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6344 +/- ##
=============================================
- Coverage 69.85% 69.85% -0.01%
+ Complexity 17922 17920 -2
=============================================
Files 2035 2035
Lines 76495 76495
Branches 7824 7824
=============================================
- Hits 53435 53434 -1
Misses 20324 20324
- Partials 2736 2737 +1 ☔ View full report in Codecov by Sentry. |
application/src/test/java/org/opentripplanner/test/support/ResourceLoader.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
approved these changes
Dec 19, 2024
tkalvas
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes test failures when building OpenTripPlanner in a folder containing URL-encodable characters (such as space, Chinese characters, etc.).
Please refer to https://stackoverflow.com/a/13470643 for details.
Issue
fixes #6337
Unit tests
Updated
Documentation
None
Changelog
Not needed
Bumping the serialization version id
Not needed